diff options
| author | Runxi Yu <me@runxiyu.org> | 2025-04-05 14:07:58 +0800 |
|---|---|---|
| committer | Runxi Yu <me@runxiyu.org> | 2025-04-05 14:07:58 +0800 |
| commit | 320d25d2c43929ddcc25cb22979bbdd3aaffd3b7 (patch) | |
| tree | f9f95697e5eb227016f0b99ffeb76f392e06d222 | |
| parent | CSS: Add margin-bottom on footer (diff) | |
| download | forge-320d25d2c43929ddcc25cb22979bbdd3aaffd3b7.tar.gz forge-320d25d2c43929ddcc25cb22979bbdd3aaffd3b7.tar.zst forge-320d25d2c43929ddcc25cb22979bbdd3aaffd3b7.zip | |
Reduce allocations when converting string to []byte
| -rw-r--r-- | http_handle_repo_index.go | 2 | ||||
| -rw-r--r-- | http_handle_repo_raw.go | 4 | ||||
| -rw-r--r-- | http_handle_repo_tree.go | 4 | ||||
| -rw-r--r-- | readme_to_html.go | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/http_handle_repo_index.go b/http_handle_repo_index.go index 36e71d7..b0a5899 100644 --- a/http_handle_repo_index.go +++ b/http_handle_repo_index.go @@ -45,7 +45,7 @@ func httpHandleRepoIndex(w http.ResponseWriter, req *http.Request, params map[st writer := bare.NewWriter(conn) reader := bare.NewReader(conn) - if err := writer.WriteData([]byte(repoPath)); err != nil { + if err := writer.WriteData(stringToBytes(repoPath)); err != nil { errorPage500(w, params, "sending repo path failed: "+err.Error()) return } diff --git a/http_handle_repo_raw.go b/http_handle_repo_raw.go index 8a9740e..5c8f626 100644 --- a/http_handle_repo_raw.go +++ b/http_handle_repo_raw.go @@ -36,7 +36,7 @@ func httpHandleRepoRaw(writer http.ResponseWriter, request *http.Request, params brWriter := bare.NewWriter(conn) brReader := bare.NewReader(conn) - if err := brWriter.WriteData([]byte(repoPath)); err != nil { + if err := brWriter.WriteData(stringToBytes(repoPath)); err != nil { errorPage500(writer, params, "sending repo path failed: "+err.Error()) return } @@ -44,7 +44,7 @@ func httpHandleRepoRaw(writer http.ResponseWriter, request *http.Request, params errorPage500(writer, params, "sending command failed: "+err.Error()) return } - if err := brWriter.WriteData([]byte(pathSpec)); err != nil { + if err := brWriter.WriteData(stringToBytes(pathSpec)); err != nil { errorPage500(writer, params, "sending path failed: "+err.Error()) return } diff --git a/http_handle_repo_tree.go b/http_handle_repo_tree.go index 0228df3..c834ad9 100644 --- a/http_handle_repo_tree.go +++ b/http_handle_repo_tree.go @@ -38,7 +38,7 @@ func httpHandleRepoTree(writer http.ResponseWriter, request *http.Request, param brWriter := bare.NewWriter(conn) brReader := bare.NewReader(conn) - if err := brWriter.WriteData([]byte(repoPath)); err != nil { + if err := brWriter.WriteData(stringToBytes(repoPath)); err != nil { errorPage500(writer, params, "sending repo path failed: "+err.Error()) return } @@ -46,7 +46,7 @@ func httpHandleRepoTree(writer http.ResponseWriter, request *http.Request, param errorPage500(writer, params, "sending command failed: "+err.Error()) return } - if err := brWriter.WriteData([]byte(pathSpec)); err != nil { + if err := brWriter.WriteData(stringToBytes(pathSpec)); err != nil { errorPage500(writer, params, "sending path failed: "+err.Error()) return } diff --git a/readme_to_html.go b/readme_to_html.go index e0212e9..c5cc706 100644 --- a/readme_to_html.go +++ b/readme_to_html.go @@ -35,7 +35,7 @@ func renderReadmeAtTree(tree *object.Tree) (string, template.HTML) { if err != nil { return "Error fetching README", escapeHTML("Unable to fetch contents of " + name + ": " + err.Error()) } - return renderReadme([]byte(contents), name) + return renderReadme(stringToBytes(contents), name) } return "", "" } |