aboutsummaryrefslogtreecommitdiff
path: root/git_hooks_handle.go (follow)
Commit message (Collapse)AuthorAgeFilesLines
* hooks: Remove debug printfRunxi Yu6 days1-2/+0
|
* hooks: Send/process environment variables starting with GIT_Runxi Yu6 days1-0/+29
|
* *: Support subgroups via SQL recursionRunxi Yu7 days1-1/+1
|
* *: Typing fixesRunxi Yu8 days1-1/+1
|
* *: Replace some := with varRunxi Yu8 days1-34/+49
|
* Add SPDX license headers to all Go filesRunxi Yu10 days1-0/+3
|
* ssh/recv: Check hooksPath before receiving packsRunxi Yu2025-02-201-20/+13
|
* hooks, ssh: Indicate URL of newly-created MRsRunxi Yu2025-02-201-3/+6
|
* hooks: Clarify the last ACK/NAK being overallRunxi Yu2025-02-201-4/+3
|
* hooks: Use colorful SSH messagesRunxi Yu2025-02-201-23/+32
|
* hooks: Don't trim contrib/ when inserting MRsRunxi Yu2025-02-191-2/+2
|
* all: Use COALESCE to handle some nullable database fieldsRunxi Yu2025-02-191-1/+6
|
* ssh/recv, hooks: Create MRs on push, reject pushes to others' MRsRunxi Yu2025-02-191-5/+32
|
* hooks: Ignore error value of the last conn.Write()Runxi Yu2025-02-191-1/+1
|
* hooks: Use ssh stderr directly instead of going through hookRunxi Yu2025-02-191-132/+99
|
* hooks: Reject non-FF contrib pushes for nowRunxi Yu2025-02-191-36/+68
| | | | We actually intend to create special refs for this in the future.
* hooks: Add TODOs on where to create MRs and MR history pointsRunxi Yu2025-02-191-0/+8
|
* *.go: Use lowercase error valuesRunxi Yu2025-02-191-2/+2
|
* hooks: Check error on conn.WriteRunxi Yu2025-02-181-12/+36
|
* *.go: Add some comments for docsRunxi Yu2025-02-181-0/+4
|
* git_hooks_handle: Allow anonymous pushes to contrib/Runxi Yu2025-02-181-2/+74
|
* hooks: Fix the race condition that causes EPIPERunxi Yu2025-02-181-0/+7
| | | | | | | | | | | | The hooks handler in the main daemon didn't wait for the hook client to write fully, and sometimes prematurely closes the connection, causing the hook client's splice to return EPIPE (or SIGPIPE if the signal handler wasn't installed). To remedy this, we call shutdown(sock, SHUT_WR) in the client, so that attempts to read on the server side return EOF. Then we can simply use io.Copy(&buf, conn) on the server side to fetch all of the data into a buffer.
* hooks, etc.: Restructure concurrency and data flowRunxi Yu2025-02-171-11/+16
| | | | | | | | | | | | | | | | | | | | | | | | | Previously we accepted handler connections at hooks_handle and used a mess of channels and concurrent maps to let receive_pack handle the session. This doesn't work well because there are conditions where a push occurs but the hook is not called, e.g. when the destination branch is up to date. There is no reliable way of checking whether the subprocess is going to call the hook or not; it's technically possible to parse stderr but that interface is not guaranteed to be stable and IIRC has changed in the past). So receive_pack would be waiting on the channel to receive a hooks connection to handle but it'll never receive one, causing a deadlock. This entire thing was overengineered and was very prone to error. Here we let receive_pack put the cookie into the map, then start and wait for the subprocess to finish. When the hook actually runs and connects to its UNIX domain socket, the handler would check its cookie within the map. If the hook doesn't run, then nothing happens. The git-receive-pack subprocess blocks the execution of the SSH handler, and when git-receive-pack exists, the SSH handler (using a defer) deletes the cookie from the map. There may be caveats in signal handling or other cases that cause the cookie to be deleted from the map prematurely.
* git_hooks_handle.go: Remove err_not_unixconnRunxi Yu2025-02-171-1/+0
| | | | | As this always suggests a programming mistake, we do not check the type assertion, causing it to panic if the types don't match.
* hooks, etc.: Authenticate hooks, and handle them in the spawning threadRunxi Yu2025-02-171-1/+23
|
* git_hooks_handle.go: Read argv from hookRunxi Yu2025-02-171-7/+33
|
* git_hooks_handle.go: Refactor for clarityRunxi Yu2025-02-171-14/+13
|
* git_hooks_handle.go: Exit on UID mismatch, handle >1 connectionsRunxi Yu2025-02-171-15/+21
|
* git_hooks_handle.go, etc.: Listen for connections from hooksRunxi Yu2025-02-171-1/+11
|
* git_hooks_handle.go: Move from git_hooks.goRunxi Yu2025-02-171-0/+45
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-13 10:58:19 +0000