From 3b20dfb6dd79c02aa6889df9e86327a54a036249 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Sat, 15 Mar 2025 13:19:21 +0800 Subject: Fix indirect memory leak when segments_from_path fails --- url.ha | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/url.ha b/url.ha index 784f602..6c4ef79 100644 --- a/url.ha +++ b/url.ha @@ -4,10 +4,19 @@ use strings; use net::uri; -// The result must be freed with strings::freeall; -fn segments_from_path(s: str) ([]str | nomem | net::uri::invalid) = { +// The result must be freed with strings::freeall. +fn segments_from_path(s: str) ([]str | nomem | uri::invalid) = { let sp: []str = strings::split(s, "/")?; - for (let i = 1z; i < len(sp); i += 1) - sp[i - 1] = net::uri::percent_decode(sp[i])?; + for (let i = 1z; i < len(sp); i += 1) { + match (uri::percent_decode(sp[i])) { + case let s: str => + sp[i - 1] = s; + case uri::invalid => + for (let j = 0z; j < i - 1; j += 1) { + free(sp[j]); + }; + return uri::invalid; + }; + }; return sp[.. len(sp) - 1]; }; -- cgit v1.2.3