From 98826d198b228e725ceb5a9fcf1d936ad3817d8e Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Sat, 5 Apr 2025 14:09:15 +0800 Subject: Reduce unnecessary allocations when converting []byte to string --- readme_to_html.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'readme_to_html.go') diff --git a/readme_to_html.go b/readme_to_html.go index c5cc706..a7a9cc3 100644 --- a/readme_to_html.go +++ b/readme_to_html.go @@ -44,7 +44,7 @@ func renderReadmeAtTree(tree *object.Tree) (string, template.HTML) { func renderReadme(data []byte, filename string) (string, template.HTML) { switch strings.ToLower(filename) { case "readme": - return "README", template.HTML("
" + html.EscapeString(string(data)) + "
") //#nosec G203 + return "README", template.HTML("
" + html.EscapeString(bytesToString(data)) + "
") //#nosec G203 case "readme.md": var buf bytes.Buffer if err := markdownConverter.Convert(data, &buf); err != nil { @@ -52,12 +52,12 @@ func renderReadme(data []byte, filename string) (string, template.HTML) { } return "README.md", template.HTML(bluemonday.UGCPolicy().SanitizeBytes(buf.Bytes())) //#nosec G203 case "readme.org": - htmlStr, err := org.New().Parse(strings.NewReader(string(data)), filename).Write(org.NewHTMLWriter()) + htmlStr, err := org.New().Parse(strings.NewReader(bytesToString(data)), filename).Write(org.NewHTMLWriter()) if err != nil { return "Error fetching README", escapeHTML("Unable to render README: " + err.Error()) } return "README.org", template.HTML(bluemonday.UGCPolicy().Sanitize(htmlStr)) //#nosec G203 default: - return filename, template.HTML("
" + html.EscapeString(string(data)) + "
") //#nosec G203 + return filename, template.HTML("
" + html.EscapeString(bytesToString(data)) + "
") //#nosec G203 } } -- cgit v1.2.3