From 71d2d56cd4b4112b33b73322d1680dd965113018 Mon Sep 17 00:00:00 2001 From: Runxi Yu Date: Wed, 15 Jan 2025 20:17:36 +0800 Subject: Minor fixes --- deliver_local.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'deliver_local.go') diff --git a/deliver_local.go b/deliver_local.go index 47af7f9..7e98aa6 100644 --- a/deliver_local.go +++ b/deliver_local.go @@ -2,16 +2,24 @@ package main import ( "context" + "errors" + "github.com/jackc/pgx/v5" "github.com/jackc/pgx/v5/pgxpool" ) -func deliver_local(ctx context.Context, db *pgxpool.Pool, envelope_from string, envelope_recipients []string, data []byte, addresses []string) error { +func deliver_local(ctx context.Context, db *pgxpool.Pool, envelope_from string, envelope_recipients []string, data []byte, addresses []string) (err error) { tx, err := db.Begin(ctx) if err != nil { return err } - defer tx.Rollback(ctx) // BUG: Potential missed error here, but this will always fail if commit succeeded + defer func() { + err = tx.Rollback(ctx) + if errors.Is(err, pgx.ErrTxClosed) { + err = nil + return + } + }() for _, address := range addresses { _, err = tx.Exec(ctx, "INSERT INTO mail (mailbox_id, data) SELECT a.mailbox_id, $2::bytea FROM addresses a JOIN mailboxes m ON a.mailbox_id = m.id WHERE a.address = $1;", address, data) if err != nil { -- cgit v1.2.3