diff options
| author | Runxi Yu <me@runxiyu.org> | 2025-08-10 05:09:27 +0800 |
|---|---|---|
| committer | Runxi Yu <me@runxiyu.org> | 2025-08-10 05:09:27 +0800 |
| commit | d6a530995a1ad130fd1d249b08ce0a5d5b566d23 (patch) | |
| tree | a50fabd08e5d6144d536783e104d672d009f89f2 /forged/internal/unsorted | |
| parent | Makefile: Remove source tarball generation (diff) | |
| download | forge-d6a530995a1ad130fd1d249b08ce0a5d5b566d23.tar.gz forge-d6a530995a1ad130fd1d249b08ce0a5d5b566d23.tar.zst forge-d6a530995a1ad130fd1d249b08ce0a5d5b566d23.zip | |
http upload pack: Don't mix stderr to stdout
Diffstat (limited to 'forged/internal/unsorted')
| -rw-r--r-- | forged/internal/unsorted/http_handle_repo_upload_pack.go | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/forged/internal/unsorted/http_handle_repo_upload_pack.go b/forged/internal/unsorted/http_handle_repo_upload_pack.go index df8bef4..02a09c5 100644 --- a/forged/internal/unsorted/http_handle_repo_upload_pack.go +++ b/forged/internal/unsorted/http_handle_repo_upload_pack.go @@ -4,7 +4,9 @@ package unsorted import ( + "bytes" "io" + "log" "net/http" "os" "os/exec" @@ -71,11 +73,13 @@ func (s *Server) httpHandleUploadPack(writer http.ResponseWriter, request *http. if stdout, err = cmd.StdoutPipe(); err != nil { return err } - cmd.Stderr = cmd.Stdout defer func() { _ = stdout.Close() }() + var stderrBuf bytes.Buffer + cmd.Stderr = &stderrBuf + if stdin, err = cmd.StdinPipe(); err != nil { return err } @@ -100,6 +104,7 @@ func (s *Server) httpHandleUploadPack(writer http.ResponseWriter, request *http. } if err = cmd.Wait(); err != nil { + log.Println(stderrBuf.String()) return err } |