diff options
| author | Runxi Yu <me@runxiyu.org> | 2025-02-19 21:24:47 +0800 |
|---|---|---|
| committer | Runxi Yu <me@runxiyu.org> | 2025-02-19 21:24:47 +0800 |
| commit | 114dd59d703d00efe86ad02eb956aa5343daa08e (patch) | |
| tree | 937eb5579864e6da5a4210fdcf943a7fb15acf07 /http_handle_login.go | |
| parent | ssh/recv, hooks: Create MRs on push, reject pushes to others' MRs (diff) | |
| download | forge-114dd59d703d00efe86ad02eb956aa5343daa08e.tar.gz forge-114dd59d703d00efe86ad02eb956aa5343daa08e.tar.zst forge-114dd59d703d00efe86ad02eb956aa5343daa08e.zip | |
all: Use COALESCE to handle some nullable database fields
Diffstat (limited to 'http_handle_login.go')
| -rw-r--r-- | http_handle_login.go | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/http_handle_login.go b/http_handle_login.go index f45db80..5aed680 100644 --- a/http_handle_login.go +++ b/http_handle_login.go @@ -23,7 +23,7 @@ func handle_login(w http.ResponseWriter, r *http.Request, params map[string]any) password := r.PostFormValue("password") var password_hash string - err := database.QueryRow(r.Context(), "SELECT id, password FROM users WHERE username = $1", username).Scan(&user_id, &password_hash) + err := database.QueryRow(r.Context(), "SELECT id, COALESCE(password, '') FROM users WHERE username = $1", username).Scan(&user_id, &password_hash) if err != nil { if errors.Is(err, pgx.ErrNoRows) { params["login_error"] = "Unknown username" @@ -33,6 +33,11 @@ func handle_login(w http.ResponseWriter, r *http.Request, params map[string]any) http.Error(w, "Error querying user information: "+err.Error(), http.StatusInternalServerError) return } + if password_hash == "" { + params["login_error"] = "User has no password" + render_template(w, "login", params) + return + } match, err := argon2id.ComparePasswordAndHash(password, password_hash) if err != nil { |